Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change inference behaviour in old TS versions #166

Merged
merged 1 commit into from
Oct 7, 2019

Conversation

phryneas
Copy link
Member

This should solve #165. I've added a new test and tested it with TS 3.5 and 3.3 (where it failed before this commit).

Feature-detecting TS<3.5 and handling it differently may not be the most elegant solution, but honestly, I don't have any better idea.

@netlify
Copy link

netlify bot commented Jul 29, 2019

Deploy preview for redux-starter-kit-docs ready!

Built with commit 5e215ed

https://deploy-preview-166--redux-starter-kit-docs.netlify.com

@markerikson
Copy link
Collaborator

@phryneas : can you rebase this on latest master?

@phryneas
Copy link
Member Author

phryneas commented Sep 7, 2019

I'll put it on the todo list :)

@phryneas
Copy link
Member Author

phryneas commented Sep 9, 2019

@markerikson okay, based on the current master now.

On a completely unrelated note, because I noticed it just now: Shouldn't we commit a yarn.lock or package.lock?

@markerikson
Copy link
Collaborator

Uh... there is a package-lock.json already.

(I personally much prefer Yarn, at least for app usage, but Redux and React-Redux are on NPM, so I kept that for consistency.)

@phryneas
Copy link
Member Author

phryneas commented Sep 9, 2019

Uh... there is a package-lock.json already.

(I personally much prefer Yarn, at least for app usage, but Redux and React-Redux are on NPM, so I kept that for consistency.)

Yup. I am blind. I'ts official now. 🤣

@markerikson
Copy link
Collaborator

Awright, let's throw this in there.

@markerikson markerikson merged commit ecc9bd3 into reduxjs:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants