Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: SerializableStateInvariantMiddleware: Use isSerializable when checking state #139

Merged
merged 1 commit into from
May 19, 2019
Merged

Fix: SerializableStateInvariantMiddleware: Use isSerializable when checking state #139

merged 1 commit into from
May 19, 2019

Conversation

ali-rantakari
Copy link
Contributor

SerializableStateInvariantMiddleware: Actually use the supplied
isSerializable function when searching for non-serialisable values
in the state.

@netlify
Copy link

netlify bot commented May 7, 2019 •
edited
Loading

Deploy preview for redux-starter-kit-docs ready!

Built with commit cb52831

https://deploy-preview-139--redux-starter-kit-docs.netlify.com

@ali-rantakari ali-rantakari force-pushed the fix/isserializable-option-fn-used branch from af9fd82 to 0e055f2 Compare May 7, 2019 07:12
@ali-rantakari
Copy link
Contributor Author

Pinging @markerikson for review please

kgregory
kgregory approved these changes May 7, 2019
View reviewed changes
Copy link
Contributor

@kgregory kgregory left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Edit: on second thought, eh

kgregory
kgregory suggested changes May 7, 2019
View reviewed changes
Copy link
Contributor

@kgregory kgregory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to abstract dispatching actions in the test.

src/serializableStateInvariantMiddleware.test.ts Outdated Show resolved Hide resolved
Fix: Use isSerializable when checking state
cb52831 
SerializableStateInvariantMiddleware: Actually use the supplied
`isSerializable` function when searching for non-serialisable values
in the state.
@ali-rantakari ali-rantakari force-pushed the fix/isserializable-option-fn-used branch from 0e055f2 to cb52831 Compare May 8, 2019 06:42
kgregory
kgregory approved these changes May 8, 2019
View reviewed changes
Copy link
Contributor

@kgregory kgregory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a maintainer, but LGTM

@markerikson
Copy link
Collaborator

Sure. Thanks!

@markerikson markerikson merged commit 364dce3 into reduxjs:master May 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgregory kgregory kgregory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ali-rantakari @markerikson @kgregory