feat(configureStore): add support for `devTools` option accepting `EnhancerOptions` #130

wldcordeiro · 2019-04-06T20:00:49Z

This is adding the code support for passing in EnhancerOptions from redux-devtools-extension for further customization.

https://github.com/zalmoxisus/redux-devtools-extension/blob/master/docs/API/Arguments.md#windowdevtoolsextensionconfig

fix #40

wldcordeiro · 2019-04-06T20:01:19Z

Going through and adding doc changes next, just wanted to get CI running to see how the code is looking.

package.json

netlify · 2019-04-06T20:02:55Z

Deploy preview for redux-starter-kit-docs ready!

Built with commit f8ce132

https://deploy-preview-130--redux-starter-kit-docs.netlify.com

wldcordeiro · 2019-04-06T20:03:36Z

src/configureStore.ts

-      // https://github.com/zalmoxisus/redux-devtools-extension/pull/624
-      trace: !IS_PRODUCTION
+      trace: !IS_PRODUCTION,
+      ...typeof devTools === 'object' && devTools,


Perhaps I can do this in a different way? I played with a couple different ways, this just seemed terse and retained behavior.

wldcordeiro

Left some comments around, I can make changes as needed too. 😄

package.json

wldcordeiro · 2019-04-06T20:28:59Z

docs/api/configureStore.md

-A boolean indicating whether `configureStore` should automatically enable support for [the Redux DevTools browser extension](https://github.com/zalmoxisus/redux-devtools-extension).
+If this is a boolean, it will be used to indicate  whether `configureStore` should automatically enable support for [the Redux DevTools browser extension](https://github.com/zalmoxisus/redux-devtools-extension).
+
+If it is an object of `redux-devtools-extension` [`EnhancerOptions`](https://github.com/zalmoxisus/redux-devtools-extension/blob/master/docs/API/Arguments.md#windowdevtoolsextensionconfig), `configureStore` will use the user provided configuration options.


I kept your note about the trace option below but this option description maybe read a little awkwardly. I wasn't sure how to best update.

wldcordeiro · 2019-04-08T21:46:32Z

@markerikson ready for review here, pushed up the last of my changes.

…hancerOptions` This is adding the code support for passing in `EnhancerOptions` from `redux-devtools-extension` for further customization. https://github.com/zalmoxisus/redux-devtools-extension/blob/master/docs/API/Arguments.md#windowdevtoolsextensionconfig fix reduxjs#40

markerikson · 2019-04-28T18:26:25Z

Awright, rebased against master after merging a couple other PRs, and looks good. Thanks!

* add onStart onError onSuccess hooks to query * code review rename original type QueryApi to BaseQueryApi, move to baseQueryTypes introduce new type QueryApi to endpointDefinitions add `await` both at query&mutationThunk `return` property * also run tests on pull requests * Remove signal from QueryApi, add endpoint desc to queries documentation * Update types, add basic lifecycle method tests Co-authored-by: Lenz Weber <mail@lenzw.de> Co-authored-by: Matt Sutkowski <msutkowski@gmail.com>