You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This package currently imports and re-exports selectorator without using it internally, while also exporting parts of the redux and immer packages that are used internally. In my opinion maintenance for both this package itself and dependent apps/packages would be easier if we removed our re-exports. This would include removing the dependency on selectorator, though in my opinion it's a very useful package and we should still recommend it in the same way in our readme.
Advantages
Less maintenance work involved in updating dependencies, and more freedom for dependent packages to update dependencies without waiting for us to update them or installing newer upstream versions. For example: Update selectorator to support the new argIndex syntax #16
Less package bloat for users that don't want the packages we recommend. For example if someone uses their own memoization library that isn't compatible with reselectorator, they won't have to set up tree shaking to remove the extra dependency if we make it optional.
Explicit understanding of where dependencies come from. Users would be aware of the packages they're using directly, but not implementation details of this package such as redux-thunk.
Closer to the intention of package.json files only including dependencies that are required internally (ignoring optionalDependences and peerDependencies which I don't think would be useful in this case).
Dependencies of dependencies don't satisfy the peer dependencies of other dependencies of a package. For example, if we kept our current behavior and someone installed a new package that peer depends on selectorator, they may have to install selectorator manually just to satisfy the peer dependency. This could cause confusion.
Disadvantages
Slightly more installation work. This could be remedied by simply adding other packages to the install script in our readme, for example npm install @acemarke/redux-starter-kit selectorator. This is a common practice in documentation for popular npm packages.
The text was updated successfully, but these errors were encountered:
This package currently imports and re-exports selectorator without using it internally, while also exporting parts of the redux and immer packages that are used internally. In my opinion maintenance for both this package itself and dependent apps/packages would be easier if we removed our re-exports. This would include removing the dependency on selectorator, though in my opinion it's a very useful package and we should still recommend it in the same way in our readme.
Advantages
Disadvantages
npm install @acemarke/redux-starter-kit selectorator
. This is a common practice in documentation for popular npm packages.The text was updated successfully, but these errors were encountered: