Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use read-dom for findDOMNode calls in LogMonitor #135

Closed
wants to merge 1 commit into from

Conversation

tomatau
Copy link

@tomatau tomatau commented Sep 28, 2015

Tiny change an makes the current build not throw red warnings when used in React 14-rc1.

Tests still pass locally.

Tiny change an makes the current build not throw red warnings when used in React 14-rc1.

Tests still pass locally.
@tomatau tomatau mentioned this pull request Sep 28, 2015
@gaearon
Copy link
Contributor

gaearon commented Sep 28, 2015

Please see #128, #114, #110. I'll happily release this when 0.14 is stable, but we can't release redux-devtools that breaks compat with React 0.13 yet, as it's a breaking change, and I don't want to maintain two stable branches until 0.14 ships.

@borisyankov
Copy link

Looking forward to not seeing the errors in the console, now that 0.14 is released ;)

@pruett
Copy link

pruett commented Oct 7, 2015

👍

@gaearon
Copy link
Contributor

gaearon commented Oct 7, 2015

Give me a few days. :-)
I'm going back from vacation, will fix when I'm home.

@sergelerator
Copy link

+1

@gaearon
Copy link
Contributor

gaearon commented Oct 7, 2015

There is no need for +1s.
As I said, I'll do this in a few days, please give me some time. ;-)

@gaearon
Copy link
Contributor

gaearon commented Oct 12, 2015

You can track this here: #152

@gaearon gaearon closed this Oct 12, 2015
@gaearon
Copy link
Contributor

gaearon commented Oct 17, 2015

Please try 3.0 Beta 2 and leave feedback.
It includes React 0.14 support: https://github.com/gaearon/redux-devtools/releases/tag/v3.0.0-beta-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants