Add dispatch shorthand example to documentation #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timdorr
reviewed
Oct 10, 2017
docs/api.md
Outdated
| // shorthand object, a map between the names of the callback props | ||
| // that we want to inject and the action creator functions that create the corresponding actions | ||
| // in this case the action creator `addTodo` will be mapped and dispatched through property `addTodo2` | ||
| // it is a good practice to keep names 1:1 to make mapping even easier - `deleteTodo` |
There was a problem hiding this comment.
We can probably drop this comment block and avoid the renaming example. It just makes this seem more complex than it is.
removed rename, simplified comment
|
Thanks! |
josepot
pushed a commit
to josepot/react-redux-lean
that referenced
this pull request
Sep 21, 2018
* Add dispatch shorthand example to documentation * Update api.md removed rename, simplified comment * Cleanups
webguru7
pushed a commit
to webguru7/react-redux
that referenced
this pull request
Dec 8, 2022
* Add dispatch shorthand example to documentation * Update api.md removed rename, simplified comment * Cleanups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reduxjs/redux#2591