Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate entry points #1761

Merged
merged 3 commits into from
Jul 8, 2021
Merged

Consolidate entry points #1761

merged 3 commits into from
Jul 8, 2021

Conversation

markerikson
Copy link
Contributor

@markerikson markerikson commented Jul 8, 2021

This PR:

  • Extracts all exported values and types into an exports.ts file
  • Updates index.ts to re-export those and call setBatch()
  • Replaces alternate-renderers.js with an alternate-renderers.ts that re-exports those and just assigns the dummy batch
  • Updates the TS types output folder to be in /es instead of /lib, just because

This should finish the initial conversion work for #1737 .

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 8, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 53bba18:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration

@github-actions
Copy link

github-actions bot commented Jul 8, 2021

Size Change: +31 B (0%)

Total Size: 19.1 kB

Filename Size Change
dist/react-redux.js 14.4 kB +31 B (0%)
ℹ️ View Unchanged
Filename Size Change
dist/react-redux.min.js 4.71 kB 0 B

compressed-size-action

@netlify
Copy link

netlify bot commented Jul 8, 2021

✔️ Deploy Preview for react-redux-docs ready!

🔨 Explore the source changes: 53bba18

🔍 Inspect the deploy log: https://app.netlify.com/sites/react-redux-docs/deploys/60e78fa3df8ed70008510970

😎 Browse the preview: https://deploy-preview-1761--react-redux-docs.netlify.app

@markerikson markerikson merged commit 918e7e9 into typescript-port Jul 8, 2021
@markerikson markerikson deleted the feature/export-types branch July 8, 2021 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant