Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wrapActionCreators #1709

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Remove wrapActionCreators #1709

merged 1 commit into from
Apr 9, 2021

Conversation

xty
Copy link
Contributor

@xty xty commented Apr 9, 2021

This is a follow-up to #1705.

After I had a look at the changes and a bit of digging, I came to realize wrapActionCreators has not been used anywhere in the codebase since 5.x, so it's really just a dangling/unreachable file that should have been removed a long time ago.

Now, the remaining question is whether we should move bindActionCreators from src/utils/bindActionCreators.js into src/connect/mapDispatchToProps.js since it is now the only place that references bindActionCreators. My own take would be to leave it as is.

Remove wrapActionCreators.js and its associated test file,
as it is no longer used anywhere in the codebase.
@netlify
Copy link

netlify bot commented Apr 9, 2021

Deploy preview for react-redux-docs ready!

Built with commit 2efa6f8

https://deploy-preview-1709--react-redux-docs.netlify.app

@timdorr
Copy link
Member

timdorr commented Apr 9, 2021

Thanks!

@timdorr timdorr merged commit 8913607 into reduxjs:master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants