Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add net6.0-maccatalyst support #99

Merged
merged 5 commits into from
Jun 24, 2022
Merged

Conversation

aritchie
Copy link
Contributor

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

This adds net6.0-maccatalyst support as well as adding a new MAUI app that targets iOS and Catalyst
To support catalyst, only one method needed to be compiler flagged:
private float GetKeyboardHeightFromNotification(NSNotification? notification, bool ignoreOrientation,
UIInterfaceOrientation orientation, ref double animationDuration) => 0;

⤵️ What is the current behavior?

N/A

🆕 What is the new behavior (if this is a feature change)?

N/A

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

Same as iOS

📝 Links to relevant issues/docs

#98

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines
  • Relevant documentation was updated

@Cheesebaron
Copy link
Collaborator

Cool! Seems to work nice.

For someone who wants to try, make sure to do:

dotnet workload install ios maccatalyst

Then you can build and run with:

dotnet build -t:Build -p:Configuration=Debug -f net6.0-maccatalyst BTProgressHUDDemo2/BTProgressHUDDemo2.csproj
dotnet build -t:Run -p:Configuration=Debug -f net6.0-maccatalyst BTProgressHUDDemo2/BTProgressHUDDemo2.csproj    

@Cheesebaron Cheesebaron merged commit bf0e483 into redth-org:master Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants