This repository has been archived by the owner on Feb 1, 2022. It is now read-only.
Rename service to inject when needed
#2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a Babel plugin which renames `service` imports to `inject` if the current Ember version doesn't support this import yet. This is a polyfill for RFC 752. More information can be found in the RFC PR: emberjs/rfcs#752
|
We're running into issues on older Ember versions that use babel-plugin-ember-modules-api-polyfill since this new It seems the ember-cached-decorator-polyfill ran into the same issue so worst case we can do something similar to what they did there? |
|
It seems that supporting versions older than 3.27 isn't really an option with the current ember-cli-babel implementation. The hack that was used for the ember-cached-decorator-polyfill no longer works and there doesn't seem to be a good alternative either. The question is... do we still release it for 3.27 and 3.28 LTS or is it really not worth it for only a couple of releases? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a Babel plugin which renames
serviceimports toinjectif the current Ember version doesn't support this import yet.This is a polyfill for RFC 752. More information can be found in the RFC PR: emberjs/rfcs#752