Skip to content

Commit

Permalink
cmake: pin seastar to c++20
Browse files Browse the repository at this point in the history
The combination of libstdc++ >= 13, c++ >= 23 and clang 16 has this bug
that caused compilation issues on ubuntu:
 * llvm/llvm-project#61415

This does not cause any compilation errors on fedora because fedora has
a patch version higher gcc and libstdc++ version.

Seastar recently upgraded to using c++23, so this is why we are seeing
this error now.
  • Loading branch information
pgellert committed May 10, 2024
1 parent 244dc53 commit 0d9ae7a
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions cmake/dependencies.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,13 @@ fetch_dep(fmt
# the add_subdirectory method of using Seastar.
set(Seastar_TESTING ON CACHE BOOL "" FORCE)
set(Seastar_API_LEVEL 6 CACHE STRING "" FORCE)
set(CMAKE_CXX_STANDARD 20)
set(Seastar_CXX_FLAGS -Wno-error)
fetch_dep(seastar
REPO https://github.com/redpanda-data/seastar.git
TAG v24.2.x
PATCH_COMMAND sed -i "s/add_subdirectory (tests/# add_subdirectory (tests/g" CMakeLists.txt)
set(CMAKE_CXX_STANDARD 20)

fetch_dep(avro
REPO https://github.com/redpanda-data/avro
Expand Down

0 comments on commit 0d9ae7a

Please sign in to comment.