Add test to assert that CHANGELOG.md gets updated
#1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisseto
requested review from
JakeSCahill,
RafalKorepta and
andrewstucki
as code owners
|
This might get annoying for just bumping appVersion, so I'm not dead set on seeing this merged. just pitching it as an option. |
RafalKorepta
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
LGTM. I run it on my local and there is an issue 👍
=== RUN TestChartYAMLVersions
lint_test.go:38:
Error Trace: /Users/rafalkorepta/workspace/redpanda/helm-charts/pkg/lint/lint_test.go:38
Error: Should be true
Test: TestChartYAMLVersions
Messages: CHANGELOG.md is missing the release header for redpanda
Did you forget to add it?
### [5.9.2](https://github.com/redpanda-data/helm-charts/releases/tag/redpanda-5.9.2)
This might get annoying for just bumping appVersion, so I'm not dead set on seeing this merged. just pitching it as an option.
Personally I would invest in new automation for auto bumps which would include appVersion bump and filling the CHANGELOG.md
This commit adds a go test that asserts that CHANGELOG.md contains a head for each Chart.yaml version in the repository. This will ensure that the CHANGELOG gets updated whenever a new chart versions are released.
chrisseto
force-pushed
the
chris/p/changelog-lint
branch
from
5a5f974 to
c00dfa8
Compare
RafalKorepta
approved these changes
Sep 14, 2024
|
If anyone finds their way back to this PR because this test is giving them grief, I give them full rights revert this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a go test that asserts that CHANGELOG.md contains a head for each Chart.yaml version in the repository.
This will ensure that the CHANGELOG gets updated whenever a new chart versions are released.