feat: add DASH support using Video.js #179
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess the biggest question you'll have is why I used Video.js http-streaming and not dash.js. To clarify, I started with dash.js actually, but the reason I switched to use Video.js is that dash.js seems more of a high level implementation. Also
preload="none"
After looking at https://github.com/iv-org/invidious I decided to follow their use of Video.js and even copied some of their work (their player theme in the file
player-invidious.css
is a direct copy). Using a full fletched player like Video.js should hopefully result in a lower maintenance load for this project.Differences with native playback:
312px
and some video's are smaller after resizing due to the height constraint.Btw, this is not a breaking change.
USE_HLS
should still work as previously. If you enable both thenUSE_VJS
has preference