Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Travis CI Configuration #94

Merged
merged 12 commits into from
Jan 23, 2018
Merged

Added Travis CI Configuration #94

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c5ecef9
Added travis config file.
brhoades Jan 18, 2018
b68adcb
Added pylint to requirements. Fixed travis call.
brhoades Jan 18, 2018
27dfa2f
Resolved most pylint errors.
brhoades Jan 19, 2018
47c32ac
StudentRepo.name -> StudentRepo.build_name
brhoades Jan 19, 2018
1d58edb
Removed FIXME for something that was fixed, created #95 for the other.
brhoades Jan 19, 2018
2936b44
Small changes after a second pass.
brhoades Jan 19, 2018
167912a
Updated changelog.
brhoades Jan 19, 2018
5c3fd31
Updated changelog (again).
brhoades Jan 19, 2018
51f4351
Restored ={} default params, split changelog.
brhoades Jan 19, 2018
ff4477f
Added pylint ignore for ={}, cleaned up unused params.
brhoades Jan 19, 2018
4bd3071
Added requirements.txt information to CONTRIBUTING.
brhoades Jan 19, 2018
6f07c75
Passing params that were unused through in baserepo, updated changelog.
brhoades Jan 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions assigner/baserepo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,12 +349,12 @@ def _gl_get(self, path, params={}):
self.url_base, path, self.token, params
)

def _gl_post(self, path, payload={}, params={}):
def _gl_post(self, path, payload={}, _=None):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should actually probably be passing params through to _cls_gl_post here...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, done. This is when happens when you fix lint without reading code.

return self.__class__._cls_gl_post(
self.url_base, path, self.token, payload
)

def _gl_put(self, path, payload={}, params={}):
def _gl_put(self, path, payload={}, _=None):
return self.__class__._cls_gl_put(
self.url_base, path, self.token, payload
)
Expand Down
1 change: 1 addition & 0 deletions pylintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ disable=print-statement,
too-many-statements,
attribute-defined-outside-init,
redefined-builtin,
dangerous-default-value,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to keep this warning on by default; in general it's correct. In baserepo.py we can do something like #pylint: disable=dangerous-default-value to silence just those warnings.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I agree.




Expand Down