Fixed get integration test errors.

redkyn · Jan 5, 2019 · 850c5c0 · 850c5c0
1 parent db443de
commit 850c5c0
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 7 deletions.
diff --git a/assigner/commands/get.py b/assigner/commands/get.py
@@ -18,6 +18,11 @@
 
 @requires_config_and_backend
 def get(conf, backend, args):
+    _get(conf, backend, args)
+
+
+# Sans decorator to ease testing
+def _get(conf, backend, args):
     """
     Creates a folder for the assignment in the CWD (or <path>, if specified)
     and clones each students' repository into subfolders.

diff --git a/assigner/tests/commands/get_integration_test.py b/assigner/tests/commands/get_integration_test.py
@@ -1,6 +1,7 @@
 from unittest.mock import call, MagicMock
 
-from assigner.commands.get import get
+from assigner.backends.base import BackendBase
+from assigner.commands.get import _get as get
 from assigner.tests.utils import AssignerIntegrationTestCase
 
 
@@ -13,31 +14,30 @@ def setUp(self):
         self.mock_roster = self._create_patch(
             "assigner.commands.get.get_filtered_roster", autospec=True
         )
-        self.mock_backend = self._create_patch(
-            "assigner.backends.MockBackend", autospec=True
-        )
         self.mock_os = self._create_patch(
             "assigner.commands.get.os", autospec=True
         )
         self.mock_prettytable = self._create_patch(
             "assigner.commands.get.PrettyTable", autospec=True
         )
 
-        self.mock_args = MagicMock(**{
+        self.mock_backend = MagicMock(spec=BackendBase)
+        self.mock_conf = MagicMock(**{
             "path": "somepath/",
             "hw_name": "HW2",
             "section": "SP2017",
             "student": MagicMock(),
             "branch": ["a", "b"],
             "force": MagicMock()
         })
+        self.mock_args = MagicMock()
 
     def test_get_no_students(self):
         """
         Test getting no student repositories.
         """
         self.mock_roster.return_value = []
-        get(self.mock_args)  # pylint: disable=no-value-for-parameter
+        get(self.mock_conf, self.mock_backend, self.mock_args)
 
         self.mock_os.path.join.assert_called_once_with(
             self.mock_args.path, self.mock_args.name
@@ -52,7 +52,7 @@ def test_get_students(self):
         Test getting some student repositories.
         """
         self.mock_roster.return_value = [MagicMock(), MagicMock()]
-        get(self.mock_args)  # pylint: disable=no-value-for-parameter
+        get(self.mock_conf, self.mock_backend, self.mock_args)
 
         for student in self.mock_roster.return_value:
             studentrepo_name = self.mock_backend.student_repo.build_name(