Add LCS #767
Merged
Add LCS #767
+226
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rueian
reviewed
Feb 17, 2025
| return cmd | ||
| } | ||
|
|
||
| func (cmd *LCSCmd) from(res rueidis.RedisResult) { |
There was a problem hiding this comment.
This parsing function seems incorrect. Is it compatible with https://github.com/redis/go-redis/blob/196fc9b21ac460f0d5251d349e4249e2ffedb9ff/command.go#L4510?
There was a problem hiding this comment.
My bad. I misunderstood what was required. I’ve added a new commit with the necessary changes.
rueian
reviewed
Feb 17, 2025
rueidiscompat/command.go
Outdated
| switch cmd.readType { | ||
| case 1: | ||
| // match string | ||
| if lcs.MatchString, err = res.ToString(); err == nil { |
There was a problem hiding this comment.
Suggested change
| if lcs.MatchString, err = res.ToString(); err == nil { | |
| if lcs.MatchString, err = res.ToString(); err != nil { |
Shouldn't this be err != nil?
rueian
reviewed
Feb 17, 2025
rueidiscompat/command.go
Outdated
| } | ||
| case 2: | ||
| // match len | ||
| if lcs.Len, err = res.AsInt64(); err == nil { |
There was a problem hiding this comment.
Suggested change
| if lcs.Len, err = res.AsInt64(); err == nil { | |
| if lcs.Len, err = res.AsInt64(); err != nil { |
Shouldn't this be err != nil?
rueidiscompat/command.go
Outdated
| } | ||
| case 3: | ||
| // read LCSMatch | ||
| if msgMap, err := res.AsMap(); err == nil { |
rueian
approved these changes
Feb 17, 2025
|
Thank you @arbha1erao |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#749