Support iter.Seq2 for *FieldValue #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think your original |
rueian
reviewed
Aug 30, 2024
rueian
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #355
I added iter.Seq2 support for
HSET,HMSET,XADDwhich haveFieldValue()method.We must support
< go 1.23, so we must split file to other files.It's hard to support auto generation because current implementation does not support code splitting.
So I hand-written the implementation.
When go version in
go.modisgo 1.23, I think we can support auto generation by adding flags to*.jsonand its structs.Consideration
I named
FieldValues, but this is maybe not good to support auto generation in the future because we must consider plural form correctly.Is
FieldValueSeqbetter?