Changes for (Add IsParseError() documentation #578) #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rueian
reviewed
Jun 24, 2024
README.md
Outdated
|
|
||
| ```golang | ||
| // Attempt to parse the response. If a parsing error occurs, check if the error is a parse error and handle it. | ||
| if err := client.Do(ctx, client.B().Get().Key("k").Build()).AsInt64(); IsParseErr(err) { |
There was a problem hiding this comment.
Suggested change
| if err := client.Do(ctx, client.B().Get().Key("k").Build()).AsInt64(); IsParseErr(err) { | |
| if err := client.Do(ctx, client.B().Get().Key("k").Build()).ToArray(); IsParseErr(err) { |
Hi @karimalzalek, thank you for fixing the document but your example, GET+AsInt64, will not return an errParse. Maybe using something like ToArray as an example will be less confusing.
Also, could you help us emphasize that a user should normally fix the code by choosing the correct parser function, not using IsParseErr, in the comment?
|
Hello @rueian , I changed the example to |
|
Hi @karimalzalek, the PR looks good to me but please remove the |
Removing wrong settings.json file
|
@rueian yup, I removed the wrong config file, not sure how that made it's way through 😂 |
SoulPancake
reviewed
Jun 26, 2024
Co-authored-by: Anurag Bandyopadhyay <angbpy@gmail.com>
|
Thanks @karimalzalek! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the section mentioning panic as behaviour is changed, and added a short error handling paragraph to explain errParse and IsPareseErr helper.