feat: send DISCARD command when conn recycled #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rueian Can you please take a look? |
rueian
reviewed
Jun 25, 2024
Co-authored-by: Rueian <rueiancsie@gmail.com>
rueian
approved these changes
Jun 26, 2024
rueian
requested changes
Jun 26, 2024
pipe_test.go
Outdated
| @@ -4129,6 +4129,11 @@ func TestPipe_CleanSubscriptions_6(t *testing.T) { | |||
| {typ: '+', string: "punsubscribe"}, | |||
| {typ: '_'}, | |||
| {typ: ':', integer: 2}, | |||
| }}, | |||
| RedisMessage{typ: '>', values: []RedisMessage{ | |||
There was a problem hiding this comment.
@SoulPancake, I found this reply is incorrect. DISCARD should reply a OK message instead of a push message.
There was a problem hiding this comment.
My bad, Addressed @rueian
rueian
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - #579