Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not ignore error of url.Parse #426

Merged
merged 1 commit into from
Dec 16, 2023
Merged

fix: do not ignore error of url.Parse #426

merged 1 commit into from
Dec 16, 2023

Conversation

j178
Copy link
Contributor

@j178 j178 commented Dec 15, 2023

If the error is ignored, there will be a nil pinter dereference panic when accessing u.Scheme.

@rueian
Copy link
Collaborator

rueian commented Dec 16, 2023

Hi @j178, good catch and thank you for the test case!

@rueian rueian merged commit 8124203 into redis:main Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants