feat: add ProbabilisticCmdable to rueidiscompat #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: CacheCompat
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #406 +/- ##
==========================================
- Coverage 97.52% 97.01% -0.51%
==========================================
Files 76 76
Lines 30866 31443 +577
==========================================
+ Hits 30101 30504 +403
- Misses 640 791 +151
- Partials 125 148 +23
☔ View full report in Codecov by Sentry. |
rueian
reviewed
Nov 12, 2023
rueidiscompat/adapter.go
Outdated
| } | ||
|
|
||
| func (c *Compat) CFLoadChunk(ctx context.Context, key string, iterator int64, data interface{}) *StatusCmd { | ||
| cmd := c.client.B().CfLoadchunk().Key(key).Iterator(iterator).Data(fmt.Sprint(data)).Build() |
There was a problem hiding this comment.
Suggested change
| cmd := c.client.B().CfLoadchunk().Key(key).Iterator(iterator).Data(fmt.Sprint(data)).Build() | |
| cmd := c.client.B().CfLoadchunk().Key(key).Iterator(iterator).Data(str(data)).Build() |
rueidiscompat/adapter.go
Outdated
| } | ||
|
|
||
| func (c *Compat) BFLoadChunk(ctx context.Context, key string, iterator int64, data interface{}) *StatusCmd { | ||
| cmd := c.client.B().BfLoadchunk().Key(key).Iterator(iterator).Data(fmt.Sprint(data)).Build() |
There was a problem hiding this comment.
Suggested change
| cmd := c.client.B().BfLoadchunk().Key(key).Iterator(iterator).Data(fmt.Sprint(data)).Build() | |
| cmd := c.client.B().BfLoadchunk().Key(key).Iterator(iterator).Data(str(data)).Build() |
rueidiscompat/adapter.go
Outdated
| func (c *Compat) CMSIncrBy(ctx context.Context, key string, elements ...interface{}) *IntSliceCmd { | ||
| _cmd := c.client.B().CmsIncrby().Key(key) | ||
| for i := 0; i < len(elements); i += 2 { | ||
| _cmd.Item(fmt.Sprint(elements[i])).Increment((int64)(elements[i+1].(int))) |
There was a problem hiding this comment.
Suggested change
| _cmd.Item(fmt.Sprint(elements[i])).Increment((int64)(elements[i+1].(int))) | |
| _cmd.Item(str(elements[i])).Increment((int64)(elements[i+1].(int))) |
|
Thank you for this great work @unknowntpo! |
|
@rueian Thanks for reviewing. |
rueian
changed the title
rueian
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduced generic
rueidiscompat.baseCmdto avoid writing boilerplate code like.Val(),.Err(),Result()for commands.And used
rueidiscompat.Scanto scan result intogo-redisstructure.