Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Normalized Vector Tests for TestVectorString32/64 #404

Merged
merged 1 commit into from
Nov 11, 2023
Merged

Conversation

h0rv
Copy link
Contributor

@h0rv h0rv commented Nov 10, 2023

Running into some issues parsing vector embeddings in a project. They vectors are normalized and was wondering if that was the issue after looking at the tests for the function. Looks like it is not but adding these tests for better coverage.

@h0rv
Copy link
Contributor Author

h0rv commented Nov 10, 2023

Looks like the tests timed out

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (98aa541) 97.52% compared to head (4972fdc) 97.53%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #404   +/-   ##
=======================================
  Coverage   97.52%   97.53%           
=======================================
  Files          76       76           
  Lines       30868    30868           
=======================================
+ Hits        30105    30106    +1     
+ Misses        639      638    -1     
  Partials      124      124           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rueian
Copy link
Collaborator

rueian commented Nov 11, 2023

Thanks @h0rv!

@rueian rueian merged commit e6b78ec into redis:main Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants