Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add FT.SEARCH to readonly commands #349

Merged
merged 1 commit into from
Aug 27, 2023
Merged

Conversation

chkp-omris
Copy link
Contributor

No description provided.

@chkp-omris
Copy link
Contributor Author

chkp-omris commented Aug 27, 2023

@rueian Reopened the PR because of permissions issue I had with the fork I created (for some reason 🤷 )
I updated hack/cmds/gen.go as requested

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (bcc9349) 97.62% compared to head (8b24fb0) 97.61%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #349      +/-   ##
==========================================
- Coverage   97.62%   97.61%   -0.01%     
==========================================
  Files          76       76              
  Lines       30467    30467              
==========================================
- Hits        29742    29740       -2     
- Misses        611      612       +1     
- Partials      114      115       +1     
Files Changed Coverage Δ
internal/cmds/gen_search.go 93.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rueian
Copy link
Collaborator

rueian commented Aug 27, 2023

Hi @chkp-omris,

Thank you very much. Would you also be willing to mark ftaggregate as readonly as well?

@rueian rueian merged commit 19e115b into redis:main Aug 27, 2023
@chkp-omris
Copy link
Contributor Author

Hi @chkp-omris,

Thank you very much. Would you also be willing to mark ftaggregate as readonly as well?

Sure, I opened a PR
Thanks

@rueian rueian changed the title add FT.SEARCH to readonly commands feat: add FT.SEARCH to readonly commands Sep 1, 2023
@rueian rueian added the feature label Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants