Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manually parse special attributes that have no associated value #239

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

justin-cechmanek
Copy link
Collaborator

When converting existing index info into a schema certain attributes have a name and value, while others are indicated as True/False only by their presence in the attributes list. These have to be removed and parsed manually before parsing the remaining items.

@justin-cechmanek
Copy link
Collaborator Author

@tylerhutcherson do we have a full list of possible attributes we need to check for?

@tylerhutcherson
Copy link
Collaborator

Let's check two places: first check the redisvl schema pydantic models for the different field types. Then, we can also check the FT.CREATE docs as a final validation.

@justin-cechmanek justin-cechmanek marked this pull request as ready for review October 29, 2024 23:56
Copy link
Collaborator

@tylerhutcherson tylerhutcherson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@justin-cechmanek justin-cechmanek merged commit 4ab6493 into main Oct 30, 2024
20 checks passed
@justin-cechmanek justin-cechmanek deleted the bugfix/RAAE-394/from_existing_error branch October 30, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants