Fix a memoization bug for cluster client #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supercaracal
deleted the
fix-cluster-client-delay-loading-for-router-module
branch
corrupt952
reviewed
Aug 21, 2024
| end | ||
|
|
||
| def server_url | ||
| @router.node_keys | ||
| @router.nil? ? @config.startup_nodes.keys : router.node_keys |
There was a problem hiding this comment.
Hi! 👋
This is related to a question I asked in https://github.com/redis-rb/redis-cluster-client/pull/364/files#r1724410379 .
I noticed that here too, the @router variable is being used directly instead of calling the router method. What's the reasoning behind this approach?
It seems that calling router would eliminate the need for the nil check. Is there a specific advantage to using @router directly in this context?
Also, I am waiting for this fix to be released!
Thanks in advance for your help!
There was a problem hiding this comment.
I thought that it would be better to delay initialization if any commands aren't sent to servers in the method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1282
I fixed redis-cluster-client to be able to delay the initialization to the first query.
But I've forgotten to fix it on redis-clustering side. So this pull request fixes it.