-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect attribute reuse in redis.connection.CacheProxyConnection #3456
Fix incorrect attribute reuse in redis.connection.CacheProxyConnection #3456
Conversation
@zs-neo Thanks for your contribution! Will mark this as a bug and will be included into next patch release |
@zs-neo Few unit tests are still failing |
632fccc
to
1423037
Compare
c99564d
to
25521e4
Compare
@vladvildanov Thanks to the useful comments in CacheProxyConnection, which helped me understand the relevant logic. I tried to fix the remaining problems, please take a look at this PR again, any suggestions are welcome. |
@zs-neo Thank you for your input! Let's finish it up and I will include it into next 5.3 GA |
|
add CacheEntry
f0721bc
to
5b1d4c1
Compare
@zs-neo It's a flacky test, I'll fix and you could rebase a branch |
Thanks a lot, I tried to fix it but I'm not too familiar with TokenManager, it would be great if you could fix it. |
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Attemp to adress #3453
CacheProxyConnection
adds caching capabilities to thesend_command
andread_response
methods, but does not clear the_current_command_cache_key
attribute.Pipeline
andClusterPipeline
usesend_packed_command
to send requests, which may cause the wrong_current_command_cache_key
to be reused during read_response.