Fix CNs in test certificates #3226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CNs in the test certificates (CA, server and client) were all the same, which is not right. Make them different. Cleanup the Jupyter notebook that documents how SSL connections work. Make the code blocks actually run, by using the test certificates. Simplify a bit the OCSP examples, since they can't run anyway due to lack of OCSP in our test infrastructure, so they are rather informative.
gerzse
force-pushed
the
fix-test-certificates-and-ssl-docs
branch
from
c283a9e to
36833f5
Compare
gerzse
force-pushed
the
fix-test-certificates-and-ssl-docs
branch
from
36833f5 to
d6d354d
Compare
dvora-h
approved these changes
May 10, 2024
gerzse
added a commit
to gerzse/redis-py
that referenced
this pull request
Jul 11, 2024
The CNs in the test certificates (CA, server and client) were all the same, which is not right. Make them different. Cleanup the Jupyter notebook that documents how SSL connections work. Make the code blocks actually run, by using the test certificates from devenv. Simplify a bit the OCSP examples, since they can't run anyway, due to lack of OCSP in our test infrastructure, so they are rather informative. Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
gerzse
added a commit
that referenced
this pull request
Jul 11, 2024
The CNs in the test certificates (CA, server and client) were all the same, which is not right. Make them different. Cleanup the Jupyter notebook that documents how SSL connections work. Make the code blocks actually run, by using the test certificates from devenv. Simplify a bit the OCSP examples, since they can't run anyway, due to lack of OCSP in our test infrastructure, so they are rather informative. Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
vladvildanov
pushed a commit
that referenced
this pull request
Sep 27, 2024
The CNs in the test certificates (CA, server and client) were all the same, which is not right. Make them different. Cleanup the Jupyter notebook that documents how SSL connections work. Make the code blocks actually run, by using the test certificates from devenv. Simplify a bit the OCSP examples, since they can't run anyway, due to lack of OCSP in our test infrastructure, so they are rather informative. Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
vladvildanov
pushed a commit
that referenced
this pull request
Sep 27, 2024
The CNs in the test certificates (CA, server and client) were all the same, which is not right. Make them different. Cleanup the Jupyter notebook that documents how SSL connections work. Make the code blocks actually run, by using the test certificates from devenv. Simplify a bit the OCSP examples, since they can't run anyway, due to lack of OCSP in our test infrastructure, so they are rather informative. Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
vladvildanov
pushed a commit
that referenced
this pull request
Sep 27, 2024
The CNs in the test certificates (CA, server and client) were all the same, which is not right. Make them different. Cleanup the Jupyter notebook that documents how SSL connections work. Make the code blocks actually run, by using the test certificates from devenv. Simplify a bit the OCSP examples, since they can't run anyway, due to lack of OCSP in our test infrastructure, so they are rather informative. Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
The CNs in the test certificates (CA, server and client) were all the same, which is not right. Make them different.
Cleanup the Jupyter notebook that documents how SSL connections work. Make the code blocks actually run, by using the test certificates. Simplify a bit the OCSP examples, since they can't run anyway due to lack of OCSP in our test infrastructure, so they are rather informative.
Fixes #3217