-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document XREAD of last message (+) #3188
Conversation
Issue redis#3155 XREAD now supports reading the last message in the stream, with the + special Id. The code already supports this, so just add some documentation to an existing Jupyter notebook.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3188 +/- ##
==========================================
- Coverage 91.84% 91.81% -0.04%
==========================================
Files 128 128
Lines 33232 33328 +96
==========================================
+ Hits 30523 30600 +77
- Misses 2709 2728 +19 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@gerzse Is there a test case that covers this? |
@vladvildanov Not an explicit unit test. The Jupyter notebook that I updated is "alive", in the sense that it can be executed, so it is sort of a proof that this works. I would not add unit tests for this, because it would test the server more than the client, I think. |
XREAD now supports reading the last message in the stream, with the + special Id. The code already supports this, so just add some documentation to an existing Jupyter notebook. Fixes redis#3155 Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
XREAD now supports reading the last message in the stream, with the + special Id. The code already supports this, so just add some documentation to an existing Jupyter notebook. Fixes #3155 Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
XREAD now supports reading the last message in the stream, with the + special Id. The code already supports this, so just add some documentation to an existing Jupyter notebook. Fixes #3155 Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
XREAD now supports reading the last message in the stream, with the + special Id. The code already supports this, so just add some documentation to an existing Jupyter notebook. Fixes #3155 Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
XREAD now supports reading the last message in the stream, with the + special Id. The code already supports this, so just add some documentation to an existing Jupyter notebook. Fixes #3155 Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
Pull Request check-list
Please make sure to review and check all of these items:
Description of change
Issue #3155
XREAD now supports reading the last message in the stream, with the + special Id. The code already supports this, so just add some documentation to an existing Jupyter notebook.