Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove typing-extensions from deps #3146

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

akx
Copy link
Contributor

@akx akx commented Feb 15, 2024

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Removes typing-extensions from dependencies.
It's not used, and this library requires Python 3.8+.

It's not used, and this library requires Python 3.8+.
@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2f88840) 91.84% compared to head (8ed507f) 91.85%.
Report is 5 commits behind head on master.

Files Patch % Lines
redis/asyncio/connection.py 83.33% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3146   +/-   ##
=======================================
  Coverage   91.84%   91.85%           
=======================================
  Files         128      128           
  Lines       33232    33272   +40     
=======================================
+ Hits        30523    30561   +38     
- Misses       2709     2711    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dvora-h dvora-h added the maintenance Maintenance (CI, Releases, etc) label Feb 18, 2024
@dvora-h dvora-h merged commit 2b2a2e0 into redis:master Feb 19, 2024
45 checks passed
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
It's not used, and this library requires Python 3.8+.
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
It's not used, and this library requires Python 3.8+.
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
It's not used, and this library requires Python 3.8+.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants