Fix incorrect asserts in test and ensure connections are closed

[kristjanvalur]

Pull Request check-list

Please make sure to review and check all of these items:

• Do tests and lints pass with this change?
• Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
• Is the new or changed code fully tested?
• Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
• Is there an example added to the examples folder (if applicable)?
• Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Various error message assertions were incorrectly placed and were not testing anything.
In addition, sockets were being leaked in the tests.

[codecov-commenter]

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (2f88840) 91.84% compared to head (a9cd991) 91.83%.
Report is 8 commits behind head on master.

Files	Patch %	Lines
tests/test_ssl.py	47.61%	11 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3004      +/-   ##
==========================================
- Coverage   91.84%   91.83%   -0.01%     
==========================================
  Files         128      128              
  Lines       33232    33283      +51     
==========================================
+ Hits        30523    30567      +44     
- Misses       2709     2716       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dvora-h]

Just to my understanding - why is this the correct way to test it?

[dvora-h]

@kristjanvalur I think you missed my question here, if you can, I would like to understand it.

[kristjanvalur]

@kristjanvalur I think you missed my question here, if you can, I would like to understand it.

I did indeed, sorry :)

with pytest.raises(ConnectionError) as e:
            sslclient.ping()
            assert "SSL: CERTIFICATE_VERIFY_FAILED" in str(e)

The above assert will never be hit. sslclient.ping() raises a connection error and the pytest.raises context manager is exited, before execution ever gets to assert.
The correct way to examine the raised exception is to examine the contents of e.value after exiting the context manager. If just grepping for a string, then str(e) is good enough too.

see https://docs.pytest.org/en/7.1.x/reference/reference.html?highlight=raises#pytest.raises

[dvora-h]

@kristjanvalur Sorry, I missed this pr. can you merge master in so I'll can merge it?

[kristjanvalur]

seems unit tests runners are shaky again.