Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in tox.ini #2578

Closed
wants to merge 3 commits into from
Closed

Fix typo in tox.ini #2578

wants to merge 3 commits into from

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Feb 7, 2023

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@dvora-h dvora-h added the maintenance Maintenance (CI, Releases, etc) label Feb 7, 2023
@dvora-h dvora-h requested a review from a team February 7, 2023 10:12
@akx
Copy link
Contributor

akx commented Mar 23, 2023

Please see #2395 and #2387...

@chayim
Copy link
Contributor

chayim commented Jun 8, 2023

Vote for closing, given how this will be handled in 5.0. WDYT?

@dvora-h
Copy link
Collaborator Author

dvora-h commented Jul 16, 2023

Not relevant anymore (see #2793)

@dvora-h dvora-h closed this Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants