Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing async test for module list #2367

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Fixing async test for module list #2367

merged 1 commit into from
Sep 7, 2022

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Sep 5, 2022

Ensuring the async test for module list behaves like the sync tests. This means that if the command is run against a redis-stack, or a redis instance, we now can assert that outputs are proper.

@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Sep 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2022

Codecov Report

Merging #2367 (b8235b0) into master (744cb09) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #2367      +/-   ##
==========================================
- Coverage   92.22%   92.21%   -0.02%     
==========================================
  Files         111      111              
  Lines       28813    28814       +1     
==========================================
- Hits        26573    26571       -2     
- Misses       2240     2243       +3     
Impacted Files Coverage Δ
tests/test_asyncio/test_commands.py 98.34% <50.00%> (-0.05%) ⬇️
tests/test_asyncio/test_pubsub.py 99.32% <0.00%> (-0.17%) ⬇️
redis/asyncio/connection.py 86.01% <0.00%> (-0.12%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dvora-h dvora-h merged commit cdba4ff into master Sep 7, 2022
@dvora-h dvora-h deleted the ck-fixasynctests branch September 7, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants