Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change dropindex() to use FT.DROPINDEX (instead FT.DROP) #2315

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Aug 2, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Fixes #2265

@dvora-h dvora-h added bug Bug breakingchange API or Breaking Change labels Aug 2, 2022
@dvora-h dvora-h requested a review from chayim August 2, 2022 08:21
@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2022

Codecov Report

Merging #2315 (26a2028) into master (f9f9d06) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2315      +/-   ##
==========================================
+ Coverage   92.08%   92.16%   +0.07%     
==========================================
  Files         109      110       +1     
  Lines       28241    28651     +410     
==========================================
+ Hits        26005    26405     +400     
- Misses       2236     2246      +10     
Impacted Files Coverage Δ
redis/commands/search/commands.py 89.10% <100.00%> (+0.02%) ⬆️
redis/cluster.py 89.85% <0.00%> (-0.53%) ⬇️
tests/test_cluster.py 96.96% <0.00%> (-0.12%) ⬇️
redis/commands/core.py 82.11% <0.00%> (ø)
redis/commands/redismodules.py 100.00% <0.00%> (ø)
tests/test_asyncio/test_graph.py 99.22% <0.00%> (ø)
tests/test_asyncio/test_cluster.py 97.41% <0.00%> (+0.13%) ⬆️
redis/commands/graph/commands.py 85.71% <0.00%> (+0.90%) ⬆️
redis/commands/graph/__init__.py 94.77% <0.00%> (+2.38%) ⬆️
redis/commands/graph/query_result.py 93.81% <0.00%> (+2.49%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@chayim
Copy link
Contributor

chayim commented Aug 2, 2022

Any idea when FT.DROP vs DROPINDEX happened?

@dvora-h
Copy link
Collaborator Author

dvora-h commented Aug 2, 2022

FT.DROP is deprecated

@dvora-h dvora-h merged commit 47b5dd0 into redis:master Aug 2, 2022
@dvora-h dvora-h deleted the dropindex branch June 18, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakingchange API or Breaking Change bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ft.dropindex() crashes server
3 participants