Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing on smembers command #2312

Merged
merged 1 commit into from
Jul 31, 2022
Merged

Conversation

agusdmb
Copy link
Contributor

@agusdmb agusdmb commented Jul 29, 2022

Pull Request check-list

The smembers command returns a set, but it is typed as returning a list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2022

Codecov Report

Merging #2312 (c749af4) into master (c94821c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2312   +/-   ##
=======================================
  Coverage   92.16%   92.16%           
=======================================
  Files         110      110           
  Lines       28642    28642           
=======================================
  Hits        26399    26399           
  Misses       2243     2243           
Impacted Files Coverage Δ
redis/commands/core.py 82.11% <100.00%> (ø)
tests/test_cluster.py 96.96% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c94821c...c749af4. Read the comment docs.

@dvora-h dvora-h added the maintenance Maintenance (CI, Releases, etc) label Jul 31, 2022
@dvora-h dvora-h merged commit fee83ae into redis:master Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants