CONFIG SET - add the ability to set multiple parameters in one call #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chayim
reviewed
Apr 27, 2022
| """Set config item ``name`` with ``value`` | ||
|
|
||
| For more information see https://redis.io/commands/config-set | ||
| """ | ||
| return self.execute_command("CONFIG SET", name, value, **kwargs) | ||
| return self.execute_command("CONFIG SET", name, value, *args, **kwargs) |
chayim
reviewed
Apr 27, 2022
| @@ -686,6 +686,16 @@ def test_config_set(self, r): | |||
| assert r.config_set("timeout", 0) | |||
| assert r.config_get()["timeout"] == "0" | |||
|
|
|||
| @skip_if_server_version_lt("7.0.0") | |||
| @skip_if_redis_enterprise() | |||
| def test_config_set_multi_params(self, r: redis.Redis): | |||
There was a problem hiding this comment.
Here's a lazy, future option for writing tests like this (psuedocode). It comes from a pattern used in go:
x = [('timeout', 70), ('maxmemory', 100)]
r.config_set(*x)
for y in x:
assert r.config_get(x[0]) == x[1]
chayim
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
$ toxpass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
closes #2122