Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw NotImplementedError for FAILOVER #1911

Merged
merged 3 commits into from
Feb 6, 2022
Merged

Throw NotImplementedError for FAILOVER #1911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e814c1d
unsupported failover
dvora-h Jan 30, 2022
c7ac5b3
add test and docstring
dvora-h Feb 3, 2022
9265291
fix docstring
dvora-h Feb 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions redis/commands/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1069,6 +1069,15 @@ def wait(self, num_replicas, timeout, **kwargs):
"""
return self.execute_command("WAIT", num_replicas, timeout, **kwargs)

def failover(self):
chayim marked this conversation as resolved.
Show resolved Hide resolved
"""
This function throws a NotImplementedError since it is intentionally
not supported.
"""
raise NotImplementedError(
"FAILOVER is intentionally not implemented in the client."
)


class BasicKeyCommands:
"""
Expand Down
5 changes: 5 additions & 0 deletions tests/test_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,6 +636,11 @@ def test_config_set(self, r):
assert r.config_set("timeout", 0)
assert r.config_get()["timeout"] == "0"

@skip_if_server_version_lt("6.0.0")
def test_failover(self, r):
with pytest.raises(NotImplementedError):
r.failover()

@pytest.mark.onlynoncluster
def test_dbsize(self, r):
r["a"] = "foo"
Expand Down