Throw NotImplementedError for AUTH #1910
Conversation
| @@ -314,6 +314,11 @@ class ManagementCommands: | |||
| Redis management commands | |||
| """ | |||
|
|
|||
| def auth(self): | |||
There was a problem hiding this comment.
Can we add a docstring indicating the behaviour. This will help users recognize we have completeness - but not use the function.
There was a problem hiding this comment.
Also - can we add a test to validate the exception is thrown?
redis/commands/core.py
Outdated
| @@ -314,6 +314,18 @@ class ManagementCommands: | |||
| Redis management commands | |||
| """ | |||
|
|
|||
| def auth(self): | |||
| """ | |||
| The AUTH command authenticates the current connection in two cases: | |||
There was a problem hiding this comment.
I think there's a miscommunication here. The docs should indicate clearly that we're raising this error, since this is intentionally not being implemented.
Codecov Report
@@ Coverage Diff @@
## master #1910 +/- ##
==========================================
+ Coverage 92.97% 93.00% +0.03%
==========================================
Files 76 76
Lines 16441 16561 +120
==========================================
+ Hits 15286 15403 +117
- Misses 1155 1158 +3
Continue to review full report at Codecov.
|
Pull Request check-list
Please make sure to review and check all of these items:
$ toxpass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.