-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for EVAL_RO #1862
Merged
Merged
Add support for EVAL_RO #1862
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0645a93
add sort_ro
dvora-h 86acf17
mark test as onlynon cluster
dvora-h 47d2e74
delete mark test as onlynoncluster
dvora-h a7cf449
add eval_ro
dvora-h 8724607
fix linters
dvora-h a694dfb
delete sort_ro
dvora-h 112ad7d
fix pr comment
dvora-h 28f12d2
add type hints
dvora-h a99f7d8
add type hints
dvora-h 48d626b
linters
dvora-h File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3881,6 +3881,9 @@ class ScriptCommands: | |
https://redis.com/ebook/part-3-next-steps/chapter-11-scripting-redis-with-lua/ | ||
""" | ||
|
||
def _eval(self, command, script, numkeys, *keys_and_args): | ||
return self.execute_command(command, script, numkeys, *keys_and_args) | ||
|
||
def eval(self, script, numkeys, *keys_and_args): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. type hints |
||
""" | ||
Execute the Lua ``script``, specifying the ``numkeys`` the script | ||
|
@@ -3892,7 +3895,19 @@ def eval(self, script, numkeys, *keys_and_args): | |
|
||
For more information check https://redis.io/commands/eval | ||
""" | ||
return self.execute_command("EVAL", script, numkeys, *keys_and_args) | ||
return self._eval("EVAL", script, numkeys, *keys_and_args) | ||
|
||
def eval_ro(self, script, numkeys, *keys_and_args): | ||
""" | ||
The read-only variant of the EVAL command | ||
|
||
Execute the read-only Lue ``script`` specifying the ``numkeys`` the script | ||
will touch and the key names and argument values in ``keys_and_args``. | ||
Returns the result of the script. | ||
|
||
For more information check https://redis.io/commands/eval_ro | ||
""" | ||
return self._eval("EVAL_RO", script, numkeys, *keys_and_args) | ||
|
||
def evalsha(self, sha, numkeys, *keys_and_args): | ||
""" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type hints...