Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConnectionError returned and not raised anymore during loading data into memory #358

Closed
ChristianScholz opened this issue Jun 14, 2013 · 3 comments

Comments

@ChristianScholz
Copy link

This commit
57f92d9
changes the behaviour if a connection error occures. This happens at our side during sync of slave and master redis servers (takes about 5 to 10secs) and requesting keys (getitem) meanwhile.
Currently we are receiving a ConnectionError object and try to handle this object as a valid result. This finally ends up in a TypeError Exception because we are expecting a string here.

The question here is if that is the expected behaviour and we are doing something wrong.
We are catching a ConnectionError and try to reconnect, but with this change the Error is not raised anymore.

@LK4D4
Copy link

LK4D4 commented Jun 14, 2013

I write some words about that here #351 (comment)

andymccurdy pushed a commit that referenced this issue Jun 14, 2013
@andymccurdy
Copy link
Contributor

Fixed. Making a PyPI release now (2.7.6).

@ChristianScholz
Copy link
Author

Thank you guys, good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants