Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect PropertyName in Aggregation query. #405

Merged
merged 5 commits into from
Aug 16, 2023
Merged

Respect PropertyName in Aggregation query. #405

merged 5 commits into from
Aug 16, 2023

Conversation

slorello89
Copy link
Member

We were pulling out the MemberInfo.Name rather than parsing the MemberExpression in our standard parser, hence it was missing the PropertyName property in the RedisSearchField attribute

@slorello89 slorello89 linked an issue Aug 16, 2023 that may be closed by this pull request
AggregationSet Where clause not using model property name #377
Closed
@slorello89 slorello89 merged commit b0f2b9e into main Aug 16, 2023
1 check passed
@slorello89 slorello89 deleted the bugfix/aggregation-custom-property-names branch August 16, 2023 14:26
@slorello89 slorello89 changed the title fixing #377 Respect PropertyName in Aggregation query. Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shacharPash shacharPash shacharPash approved these changes

@bsbodden bsbodden Awaiting requested review from bsbodden

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AggregationSet Where clause not using model property name
2 participants
@slorello89 @shacharPash