chore(build): fix npm run build command #3097
Open
+31
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
importing from 'package.json' messes typescript, as it starts thinking it depends on the files it wants to write, resulting in build errors if the dist folders are not deleted. ultimately it was very annoying to delete all dist folders and then build when you just want to build. and its also much slower because you loose all your cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
importing from 'package.json' messes typescript, as it starts thinking it depends on the files it wants to write, resulting in build errors if the dist folders are not deleted. ultimately it was very annoying to delete all dist folders and then build when you just want to build. and its also much slower because you loose all your cache
Checklist
npm testpass with this change (including linting)?