Command Parser #2716
Open
Command Parser #2716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivated by wanting to return a read only array from the parser object
This was referenced Apr 2, 2024
leibale
reviewed
May 16, 2024
| } | ||
|
|
||
| setCachable() { | ||
| this.#cachable = true; |
There was a problem hiding this comment.
is cachable "dynamic" (can be either true or false depending on the command arguments)? if not, we should move it from the parser to a constant property on the command.
| client = redirectTo; | ||
|
|
||
| const chainId = Symbol('Asking Chain'); |
There was a problem hiding this comment.
is this fix part of another PR too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Start of implementation of changing how command arguments are transformed to enable easier and more consistent usage across the different clients we have and to enable client side caching.
Checklist
npm testpass with this change (including linting)?