Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #2364 - fix FT.SEARCH RETURN [] #2366

Merged
merged 2 commits into from
Jan 18, 2023
Merged

fix #2364 - fix FT.SEARCH RETURN [] #2366

merged 2 commits into from
Jan 18, 2023

Conversation

leibale
Copy link
Contributor

@leibale leibale commented Jan 4, 2023

fix #2364 - fix FT.SEARCH RETURN []

guyroyse
guyroyse requested changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@guyroyse guyroyse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the stray console.log.

packages/search/lib/commands/SEARCH.ts Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2023 •
edited
Loading

Codecov Report

Base: 95.85% // Head: 95.79% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (d1a388a) compared to base (c5b6f77).
Patch coverage: 73.33% of modified lines in pull request are covered.

❗ Current head d1a388a differs from pull request most recent head fc87411. Consider uploading reports for the commit fc87411 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2366      +/-   ##
==========================================
- Coverage   95.85%   95.79%   -0.07%     
==========================================
  Files         449      449              
  Lines        4224     4235      +11     
  Branches      471      472       +1     
==========================================
+ Hits         4049     4057       +8     
- Misses        107      110       +3     
  Partials       68       68
Impacted Files Coverage Δ
packages/search/lib/commands/SEARCH.ts 83.33% <73.33%> (-8.98%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

guyroyse
guyroyse approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@guyroyse guyroyse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheArmagan
Copy link

Please approve that pull request its needed.

TheArmagan
TheArmagan approved these changes Jan 11, 2023
View reviewed changes
Copy link

@TheArmagan TheArmagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks ok to me

@leibale
Copy link
Contributor Author

leibale commented Jan 11, 2023

This will get released once #2373 is ready

@leibale leibale merged commit a1dfa22 into redis:master Jan 18, 2023
@leibale leibale mentioned this pull request Feb 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheArmagan TheArmagan TheArmagan approved these changes

@guyroyse guyroyse guyroyse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node Redis cannot return empty documents
4 participants
@leibale @codecov-commenter @TheArmagan @guyroyse