-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support tls on redis url #1268
Comments
I am against adding this. The reason is that it is not possible to add all |
Mongodb for example manage it... https://docs.mongodb.com/manual/reference/connection-string/ |
I don't see why it's necessary "to add all tls options with the url". From an operations perspective it would be good enough to just enable TLS encryption for the connection – establishing the trust relationship should be handled by the operation system eitherway (installed root/intermediate certificate authorities; see /etc/ssl on Linux). I really don't want to take a deep-dive into each and every programming language's settings in order to "just enable TLS". It basically should be a yes/no thing. This is what the rediss uri scheme provides. Other client libraries (in other languages) already support this:
By not providing this feature it makes it necessary to keep a separate configuration for node.js. |
Seems like there was enough interest in this feature for me to reconsider this. |
Is an NPM release for this feature planned soon? 2.8.0 is the latest, which doesn't have this feature. |
What about a lesser form of this that does something like set default tls options it can set from the URL without extending the format? Setting I don't know about others, but I know that at least compose.io uses SNI for Redis over SSL. |
Use master version of Node Redis client for now, because TLS support is not yet officially released: redis/node-redis#1268 redis/node-redis#1282
Use master version of Node Redis client for now, because TLS support is not yet officially released: redis/node-redis#1268 redis/node-redis#1282
Use master version of Node Redis client for now, because TLS support is not yet officially released: redis/node-redis#1268 redis/node-redis#1282
I've just published v3.0.0 to NPM; https://github.com/NodeRedis/node-redis/releases/tag/v3.0.0 - which includes the change @calebboyd mentioned, can this issue be closed now? |
Example :
rediss://:password@rediss:6400/1?rejectUnauthorized=false
https://www.iana.org/assignments/uri-schemes/prov/redis
The text was updated successfully, but these errors were encountered: