Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support up to max unsigned integer in Bitfield offset (#2964) #3099

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

psw0946
Copy link
Contributor

@psw0946 psw0946 commented Dec 24, 2024

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

Some offset field types were long, some were int. I unified them into int type.
Bitfield offset did not support unsigned integer value, so I fixed it.
#2964

Copy link
Collaborator

@tishun tishun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the contribution!

@tishun tishun added this to the 6.6.0.RELEASE milestone Dec 27, 2024
@tishun tishun merged commit b925816 into redis:main Dec 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants