Move SSL management to a distinct private pointer. #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to allow our users to use redisContext->privdata as context for any RESP3 PUSH messages, which means we can't use it for managing SSL connections. Bulletpoints: * Create a secondary redisContext member for internal use only called privctx and rename the redisContextFuncs->free_privdata accordingly. * Adds a `free_privdata` function pointer so the user can tie allocated memory to the lifetime of a redisContext (like they can already do with redisAsyncContext) * Enables SSL tests in .travis.yml
|
@yossigo I'm not overly fluent in CMake so if there is a better way to structure the changes in Also, in the future, I'll try to get the SSL tests running in 32 bit Travis builds as well but running them at all in CI is a decent improvement. |
yossigo
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to allow our users to use
redisContext->privdataas contextfor any RESP3 PUSH messages, which means we can't use it for managing
SSL connections.
Bullet points:
Create a secondary redisContext member for internal use only called
privctxand rename theredisContextFuncs->free_privdataaccordingly.Adds a
free_privdatafunction pointer so the user can tie allocatedmemory to the lifetime of a redisContext (like they can already do
with
redisAsyncContext)Enables SSL tests in .travis.yml (On Linux/OSX 64 bit)