Update createArray to take size_t #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes createArray consistent with createString, which also takes size_t. Bounds-check and unit tests are updated to allow up to min(SIZE_MAX,LLONG_MAX). Changelog is updated to mention this API break. Signed-off-by: Justin Brewer <jzb0012@auburn.edu>
This should have been included in 93421f9 but was missed. Signed-off-by: Justin Brewer <jzb0012@auburn.edu>
|
Good catch on 300fc01. I went ahead and cherry-picked that into master. The breaking change is trickier but it would appear that the main downstream repos hiredis-rb, hiredis-py, and hiredis-node all pin to specific versions. I figure we leave this up for a few days and then go ahead and get it merged if there are no objections. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes createArray consistent with createString, which also takes size_t. Bounds-check and unit tests are updated to allow up to
min(SIZE_MAX,LLONG_MAX). Changelog is updated to mention this API break.Also included is a missed Changelog entry mentioning the integer parsing changes.