Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nil pointer dereferencing in writeArg #3271

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aliforever
Copy link

  • Added example for hset using struct
  • Added nil pointer checks to WriteArg (internal/proto/writer.go:62)
  • Added test cases

Issue: #3208

@ndyakov
Copy link
Collaborator

ndyakov commented Feb 10, 2025

Hello @aliforever, Looking at the example test, don't you think we should add a check with omitempty to verify the nil pointers will be retrieved as such? Other than that, lgtm. Maybe remove the dump package from the test so the linter passes? For some reason it doesn't like it. Will review once we have that test updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants