Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-4335 added aggregate query examples #3259

Merged

Conversation

andy-stark-redis
Copy link
Contributor

@andy-stark-redis andy-stark-redis commented Jan 31, 2025

DOC-4335

Go examples for the aggregation query page.

NOTE: the second and third examples would require a more advanced query builder class to produce the right aggregation commands, so I've left these out for now.

@andy-stark-redis andy-stark-redis self-assigned this Jan 31, 2025
@andy-stark-redis andy-stark-redis changed the title DOC-4335 added aggregate query examples (demonstrating errors) DOC-4335 added aggregate query examples Jan 31, 2025
@andy-stark-redis andy-stark-redis marked this pull request as ready for review January 31, 2025 13:35
@ndyakov
Copy link
Collaborator

ndyakov commented Feb 7, 2025

@andy-stark-redis we are fixing some issues with the FTAggregate in #3263 , maybe you can wait for it to be merged and revisit this one ?

@ndyakov ndyakov self-requested a review February 7, 2025 08:42
@andy-stark-redis
Copy link
Contributor Author

@andy-stark-redis we are fixing some issues with the FTAggregate in #3263 , maybe you can wait for it to be merged and revisit this one ?

@ndyakov Thanks for the info! I've got the missing examples working now, so the full set is ready for review.

@ndyakov ndyakov merged commit 71311d8 into redis:master Feb 10, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants