Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: Support for COMMAND LIST command #2491

Merged
merged 10 commits into from
Mar 19, 2023
Merged

Add: Support for COMMAND LIST command #2491

merged 10 commits into from
Mar 19, 2023

Conversation

SoulPancake
Copy link
Contributor

Fixes #2389

@SoulPancake SoulPancake marked this pull request as ready for review March 19, 2023 08:05
@SoulPancake
Copy link
Contributor Author

@monkey92t @chayim Can you please review this?

monkey92t
monkey92t reviewed Mar 19, 2023
View reviewed changes
command.go Outdated Show resolved Hide resolved
monkey92t
monkey92t reviewed Mar 19, 2023
View reviewed changes
commands.go Outdated Show resolved Hide resolved
monkey92t
monkey92t reviewed Mar 19, 2023
View reviewed changes
command.go Outdated Show resolved Hide resolved
@monkey92t
Copy link
Collaborator

Maybe we can use the shortcut API

CommandList(ctx) []string
CommandListByModel(ctx, modelName) []string
CommandListByACLCat...
CommandListByPattern...

@SoulPancake
Copy link
Contributor Author

Hmm, We can do that as well
But this seems more elegant to me, as the reply types are pretty same so having a filterBy opt seems better
Whatever you decide

@monkey92t
Copy link
Collaborator

It seems better to use pointers:

CommandList(ctx context.Context, opt *FilterBy) *StringSliceCmd

client.CommandList(ctx, &redis.FilterBy{...})
client.CommandList(ctx, nil)

OR

CommandList(ctx context.Context, opt FilterBy) *StringSliceCmd

client.CommandList(ctx, redis.FilterBy{...})
client.CommandList(ctx, redis.FilterBy{})

@monkey92t
Copy link
Collaborator

I vote for the pointer...

monkey92t
monkey92t reviewed Mar 19, 2023
View reviewed changes
commands.go Outdated Show resolved Hide resolved
@SoulPancake SoulPancake requested a review from monkey92t March 19, 2023 09:16
monkey92t
monkey92t reviewed Mar 19, 2023
View reviewed changes
commands_test.go Outdated Show resolved Hide resolved
monkey92t
monkey92t reviewed Mar 19, 2023
View reviewed changes
commands.go Outdated Show resolved Hide resolved
@monkey92t
Copy link
Collaborator

Overall it looks good~

monkey92t
monkey92t reviewed Mar 19, 2023
View reviewed changes
commands.go Outdated Show resolved Hide resolved
@SoulPancake SoulPancake requested a review from monkey92t March 19, 2023 10:18
@monkey92t monkey92t merged commit 049d4f9 into redis:master Mar 19, 2023
@monkey92t
Copy link
Collaborator

:)

@SoulPancake
Copy link
Contributor Author

Thanks @monkey92t

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monkey92t monkey92t monkey92t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for COMMAND LIST command
2 participants
@SoulPancake @monkey92t